Skip to content

Docs: complete cut-off sentence in “Preparing a pull request” section#3721

Merged
raclim merged 6 commits into
processing:developfrom
sdass1918:fix-docs-pr-template
Feb 3, 2026
Merged

Docs: complete cut-off sentence in “Preparing a pull request” section#3721
raclim merged 6 commits into
processing:developfrom
sdass1918:fix-docs-pr-template

Conversation

@sdass1918
Copy link
Copy Markdown
Contributor

Fixes #3596

This PR fixes a cut-off sentence in contributor_docs/preparing_a_pull_request.md under the “Pull Request Templates” section.

Changes:
Completed the missing text explaining the verification steps contributors should check before submitting a PR.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

Copy link
Copy Markdown
Contributor

@yugalkaushik yugalkaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdass1918 Thank you for the PR, I think along with the code related to this PR you pushed some translation code, Please review them once.

@sdass1918 sdass1918 force-pushed the fix-docs-pr-template branch from 0a58072 to 487ad98 Compare November 10, 2025 17:49
@sdass1918
Copy link
Copy Markdown
Contributor Author

@yugalkaushik
Thanks for pointing that out, I’ve removed the extra translation files and kept only the doc changes.

@sdass1918
Copy link
Copy Markdown
Contributor Author

Hello! @yugalkaushik Following up on this PR—I've addressed the feedback regarding the translation files and updated the branch with only the relevant documentation changes.
Kindly let me know if there are any further adjustments required.

Copy link
Copy Markdown
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your work on this @sdass1918 and for the review @yugalkaushik!

@raclim raclim merged commit 155b4e8 into processing:develop Feb 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text cut off in contributor docs under "Preparing a pull request"

3 participants